fix(oracle): escape SQL identifiers and literals in metadata/DDL paths (#1914) - #2195
Merged
Conversation
…intainer review (OtterMind#1914) - strengthen OracleIdentifierProcessor: INSTANCE, escapeString with single-quote doubling, static escapeIdentifier/quoteIdentifierAlways - OracleMetaData processor singleton delegates to INSTANCE; private escapeSqlLiteral (OtterMind#2052) unified to processor escapeString - builders/DBManager/enums/value processors use the processor (or OracleSqlGuards for non-escapable validation) - OracleSqlEscapes removed; tests migrated (33 green)
openai0229
force-pushed
the
fix/sqli2-oracle
branch
from
July 29, 2026 08:45
0e8e47c to
ba41831
Compare
openai0229
approved these changes
Jul 29, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Maintainer review complete. Rebased onto current main, preserved Oracle identifier/literal semantics, and verified with the eight-module clean reactor test suite (160/160 tests passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1914
Summary
Completes the Oracle database-plugin portion of the identifier and literal escaping work.
quoteIdentifier(...)behavior for completion and lookup while usingquoteIdentifierAlways(...)at generated-DDL sites.Affected surfaces
Verification
mvn -B -f chat2db-community-server/pom.xml -pl chat2db-community-plugins/chat2db-community-oracle -am clean test -DskipTests=false -Dmaven.test.skip=false -Dsurefire.failIfNoSpecifiedTests=falseBUILD SUCCESSacross 8 reactor modules; 160 tests passed in tested modules, including Oracle44/44, SPI90/90, and tools26/26.git diff --check origin/main...HEAD: passed.Risk and compatibility
ISQLIdentifierProcessorcontract.Reviewer map
OracleIdentifierProcessor,OracleSqlGuards, thenOracleSqlBuilderandOracleMetaData.Contributor declaration
AI assistance: Substantial AI-assisted maintainer revision, review, and test expansion; all final changes were source-reviewed and verified with the commands above.